From 50a73d21eb3cabb533dc5e059386dd4382cfd1be Mon Sep 17 00:00:00 2001
From: Oliver Booth <git@olivr.me>
Date: Wed, 14 Feb 2024 15:22:41 +0000
Subject: [PATCH] perf: remove LINQ in ctor lookup

---
 TcpDotNet/ClientNode.cs | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/TcpDotNet/ClientNode.cs b/TcpDotNet/ClientNode.cs
index 28ebda8..bb29390 100644
--- a/TcpDotNet/ClientNode.cs
+++ b/TcpDotNet/ClientNode.cs
@@ -140,10 +140,7 @@ public abstract class ClientNode : Node
             return null;
         }
 
-        const BindingFlags bindingFlags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance;
-        ConstructorInfo? constructor =
-            packetType.GetConstructors(bindingFlags).FirstOrDefault(c => c.GetParameters().Length == 0);
-
+        ConstructorInfo? constructor = GetConstructor(packetType);
         if (constructor is null)
             return null;
 
@@ -259,6 +256,24 @@ public abstract class ClientNode : Node
         return WaitForPacketAsync<TPacket>(completionSource, cancellationToken);
     }
 
+    private static ConstructorInfo? GetConstructor(Type packetType)
+    {
+        const BindingFlags bindingFlags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance;
+        ConstructorInfo[] constructors = packetType.GetConstructors(bindingFlags);
+        ConstructorInfo? constructor = null;
+        for (var index = 0; index < constructors.Length; index++)
+        {
+            ConstructorInfo current = constructors[index];
+            if (current.GetParameters().Length == 0)
+            {
+                constructor = current;
+                break;
+            }
+        }
+
+        return constructor;
+    }
+
     private async Task<TPacket> WaitForPacketAsync<TPacket>(TaskCompletionSource<Packet> completionSource,
         CancellationToken cancellationToken = default)
         where TPacket : Packet