From e7dfe97c6df90aaf4d3ca752cddc42f4b882d683 Mon Sep 17 00:00:00 2001
From: Oliver Booth <git@olivr.me>
Date: Mon, 12 Feb 2024 17:30:56 +0000
Subject: [PATCH] refactor!: remove TSend generic parameter from
 SendAndReceiveAsync

---
 TcpDotNet.ClientIntegrationTest/Program.cs | 4 ++--
 TcpDotNet/BaseClientNode.cs                | 4 +---
 TcpDotNet/ProtocolClient.cs                | 2 +-
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/TcpDotNet.ClientIntegrationTest/Program.cs b/TcpDotNet.ClientIntegrationTest/Program.cs
index ada9729..0ecd968 100644
--- a/TcpDotNet.ClientIntegrationTest/Program.cs
+++ b/TcpDotNet.ClientIntegrationTest/Program.cs
@@ -1,4 +1,4 @@
-using System.Net;
+using System.Net;
 using TcpDotNet;
 using TcpDotNet.ClientIntegrationTest;
 using TcpDotNet.ClientIntegrationTest.PacketHandlers;
@@ -17,7 +17,7 @@ Console.WriteLine($"Connected to {client.RemoteEndPoint}. My session is {client.
 
 var ping = new PingPacket();
 Console.WriteLine($"Sending ping packet with payload: {BitConverter.ToString(ping.Payload)}");
-var pong = await client.SendAndReceiveAsync<PingPacket, PongPacket>(ping);
+var pong = await client.SendAndReceiveAsync<PongPacket>(ping);
 
 Console.WriteLine($"Received pong packet with payload: {BitConverter.ToString(pong.Payload)}");
 Console.WriteLine(pong.Payload.SequenceEqual(ping.Payload) ? "Payload matches!" : "Payload does not match!");
diff --git a/TcpDotNet/BaseClientNode.cs b/TcpDotNet/BaseClientNode.cs
index 9670bb0..c1df784 100644
--- a/TcpDotNet/BaseClientNode.cs
+++ b/TcpDotNet/BaseClientNode.cs
@@ -221,15 +221,13 @@ public abstract class BaseClientNode : Node
     /// </summary>
     /// <param name="packetToSend">The packet to send.</param>
     /// <param name="cancellationToken">A cancellation token that can be used to cancel the asynchronous operation.</param>
-    /// <typeparam name="TSend">The type of the packet to send.</typeparam>
     /// <typeparam name="TReceive">The type of the packet to return.</typeparam>
     /// <returns>The received packet.</returns>
     /// <remarks>
     ///     This method will consume all incoming packets, raising their associated handlers if such packets are recognised.
     /// </remarks>
-    public async Task<TReceive> SendAndReceiveAsync<TSend, TReceive>(TSend packetToSend,
+    public async Task<TReceive> SendAndReceiveAsync<TReceive>(Packet packetToSend,
         CancellationToken cancellationToken = default)
-        where TSend : Packet
         where TReceive : Packet
     {
         var attribute = typeof(TReceive).GetCustomAttribute<PacketAttribute>();
diff --git a/TcpDotNet/ProtocolClient.cs b/TcpDotNet/ProtocolClient.cs
index 1294eb8..ff9979b 100644
--- a/TcpDotNet/ProtocolClient.cs
+++ b/TcpDotNet/ProtocolClient.cs
@@ -96,7 +96,7 @@ public sealed class ProtocolClient : BaseClientNode
         State = ClientState.Handshaking;
         var handshakeRequest = new HandshakeRequestPacket(ProtocolVersion);
         var handshakeResponse =
-            await SendAndReceiveAsync<HandshakeRequestPacket, HandshakeResponsePacket>(handshakeRequest, cancellationToken);
+            await SendAndReceiveAsync<HandshakeResponsePacket>(handshakeRequest, cancellationToken);
 
         if (handshakeResponse.HandshakeResponse != HandshakeResponse.Success)
         {