From 373313f07e4b364bbf5cd9168a4dbdcd1eefba75 Mon Sep 17 00:00:00 2001
From: Oliver Booth <me@olivr.me>
Date: Sat, 18 Apr 2020 14:31:29 +0100
Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20Change=20IE<byte>.Chunkify=20to=20I?=
 =?UTF-8?q?E<T>.Split?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Thereby adding support for any IEnumerable<T>, and naming
convention is consistent with .NET and removes warnings of a
non-existent word
---
 X10D/src/ByteExtensions.cs       | 22 ----------------------
 X10D/src/EnumerableExtensions.cs | 31 +++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 22 deletions(-)
 create mode 100644 X10D/src/EnumerableExtensions.cs

diff --git a/X10D/src/ByteExtensions.cs b/X10D/src/ByteExtensions.cs
index 02302cf..3412cfc 100644
--- a/X10D/src/ByteExtensions.cs
+++ b/X10D/src/ByteExtensions.cs
@@ -20,28 +20,6 @@
             return BitConverter.ToString(bytes.ToArray());
         }
 
-        /// <summary>
-        /// Splits <paramref name="bytes"/> into chunks of size <paramref name="chunkSize"/>.
-        /// </summary>
-        /// <param name="bytes">The collection to split.</param>
-        /// <param name="chunkSize">The maximum length of the nested <see cref="byte"/> collection.</param>
-        /// <returns>Returns an <see cref="IEnumerable{T}"/> of <see cref="IEnumerable{T}"/> of <see cref="byte"/>
-        /// values.</returns>
-        public static IEnumerable<IEnumerable<byte>> Chunkify(this IEnumerable<byte> bytes, int chunkSize)
-        {
-            IEnumerable<byte>       enumerable = bytes as byte[] ?? bytes.ToArray();
-            long                    count      = enumerable.LongCount();
-            List<IEnumerable<byte>> chunks     = new List<IEnumerable<byte>>();
-            chunkSize = chunkSize.Clamp(1, enumerable.Count());
-
-            for (int i = 0; i < (int) (count / chunkSize); i++)
-            {
-                chunks.Add(enumerable.Skip(i * chunkSize).Take(chunkSize));
-            }
-
-            return chunks.ToArray();
-        }
-
         /// <summary>
         /// Converts the <see cref="byte"/>[] to an <see cref="short"/>.
         /// </summary>
diff --git a/X10D/src/EnumerableExtensions.cs b/X10D/src/EnumerableExtensions.cs
new file mode 100644
index 0000000..d82b0ff
--- /dev/null
+++ b/X10D/src/EnumerableExtensions.cs
@@ -0,0 +1,31 @@
+namespace X10D
+{
+    using System.Collections.Generic;
+    using System.Linq;
+
+    /// <summary>
+    /// Extension methods for <see cref="IEnumerable{T}"/>.
+    /// </summary>
+    public static class EnumerableExtensions
+    {
+        /// <summary>
+        /// Splits <paramref name="value"/> into chunks of size <paramref name="chunkSize"/>.
+        /// </summary>
+        /// <typeparam name="T">Any type.</typeparam>
+        /// <param name="value">The collection to split.</param>
+        /// <param name="chunkSize">The maximum length of the nested <see cref="byte"/> collection.</param>
+        /// <returns>Returns an <see cref="IEnumerable{T}"/> of <see cref="IEnumerable{T}"/> of <see cref="byte"/>
+        /// values.</returns>
+        public static IEnumerable<IEnumerable<T>> Split<T>(this IEnumerable<T> value, int chunkSize)
+        {
+            T[] enumerable = value.ToArray();
+            var count = enumerable.LongCount();
+            chunkSize = chunkSize.Clamp(1, enumerable.Length);
+
+            for (var i = 0; i < (int)(count / chunkSize); i++)
+            {
+                yield return enumerable.Skip(i * chunkSize).Take(chunkSize);
+            }
+        }
+    }
+}