oliverbooth/X10D
oliverbooth/X10D
1
0
Fork 0
mirror of https://github.com/oliverbooth/X10D synced 2024-11-24 18:38:47 +00:00
Code Issues

fix: revert c7e78f5d19

Browse Source
This commit is contained in:
Oliver Booth 2024-11-14 16:15:37 +00:00
parent 0be10d819f
commit 44d3aec9a6
Signed by: oliverbooth
GPG Key ID: 2A862C3F46178E8E
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -9,8 +9,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- X1OD: `IBinaryInteger<T>.Factorial` now starts at `IBinaryInteger<T>.MultiplicativeIdentity` not
`IBinaryInteger<T>.One`.
- X10D: Removed `IEnumerable<T>.GreatestCommonFactor` for all integer types in favour of generic math. - X10D: Removed `IEnumerable<T>.GreatestCommonFactor` for all integer types in favour of generic math.
- X10D: Removed `IEnumerable<T>.LowestCommonMultiple` for all integer types in favour of generic math. - X10D: Removed `IEnumerable<T>.LowestCommonMultiple` for all integer types in favour of generic math.
- X10D: Removed `IEnumerable<T>.Product` for all integer types in favour of generic math. - X10D: Removed `IEnumerable<T>.Product` for all integer types in favour of generic math.

6
X10D/src/Math/BinaryIntegerExtensions.cs
View File

@ -69,12 +69,12 @@ public static class BinaryIntegerExtensions
return 1; return 1;
} }
TInteger result = TInteger.MultiplicativeIdentity; long result = 1L;
for (TInteger i = TInteger.One; i <= value; i++) for (TInteger i = TInteger.One; i <= value; i++)
{ {
result *= i; result *= long.CreateChecked(i);
} }
return long.CreateChecked(result); return result;
} }
} }