From a1af553c931deb6c988a726d5c4c1a63f1af6257 Mon Sep 17 00:00:00 2001 From: Oliver Booth Date: Wed, 10 Mar 2021 11:32:59 +0000 Subject: [PATCH] Cache exception message to prevent long line --- .../ReflectionExtensions/TypeExtensions.cs | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/X10D/src/ReflectionExtensions/TypeExtensions.cs b/X10D/src/ReflectionExtensions/TypeExtensions.cs index f72ce83..1a28d11 100644 --- a/X10D/src/ReflectionExtensions/TypeExtensions.cs +++ b/X10D/src/ReflectionExtensions/TypeExtensions.cs @@ -93,9 +93,10 @@ namespace X10D.ReflectionExtensions if (!interfaceType.IsInterface) { - throw new ArgumentException( - string.Format(CultureInfo.CurrentCulture, ExceptionMessages.TypeIsNotInterface, interfaceType), - nameof(interfaceType)); + var exceptionMessage = ExceptionMessages.TypeIsNotInterface; + var formattedMessage = string.Format(CultureInfo.CurrentCulture, exceptionMessage, interfaceType); + + throw new ArgumentException(formattedMessage, nameof(interfaceType)); } return Array.IndexOf(value.GetInterfaces(), interfaceType) >= 0; @@ -139,16 +140,18 @@ namespace X10D.ReflectionExtensions if (!value.IsClass) { - throw new ArgumentException( - string.Format(CultureInfo.CurrentCulture, ExceptionMessages.TypeIsNotClass, value), - nameof(value)); + var exceptionMessage = ExceptionMessages.TypeIsNotClass; + var formattedMessage = string.Format(CultureInfo.CurrentCulture, exceptionMessage, value); + + throw new ArgumentException(formattedMessage, nameof(value)); } if (!type.IsClass) { - throw new ArgumentException( - string.Format(CultureInfo.CurrentCulture, ExceptionMessages.TypeIsNotClass, type), - nameof(type)); + var exceptionMessage = ExceptionMessages.TypeIsNotClass; + var formattedMessage = string.Format(CultureInfo.CurrentCulture, exceptionMessage, type); + + throw new ArgumentException(formattedMessage, nameof(type)); } return value.IsSubclassOf(type);