oliverbooth/X10D
oliverbooth/X10D
1
0
Fork 0
mirror of https://github.com/oliverbooth/X10D synced 2024-11-21 20:18:49 +00:00
Code Issues

refactor!: remove DateOnly.Deconstruct

Browse Source
This commit is contained in:
Oliver Booth 2024-11-14 17:35:19 +00:00
parent 027f6f23e1
commit bdef9b1442
Signed by: oliverbooth
GPG Key ID: 2A862C3F46178E8E
3 changed files with 3 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -20,8 +20,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Removed
- X10D: Removed `DateOnly.Deconstruct` due to conflict with
[`System.DateOnly.Deconstruct`](https://learn.microsoft.com/en-us/dotnet/api/system.datetime.deconstruct?view=net-8.0).
- X10D: Removed `Span<T>.Split` for .NET 9.0 target due to conflicts with
[`System.MemoryExtensions.Split`](https://learn.microsoft.com/en-us/dotnet/api/system.memoryextensions.split?view=net-8.0).
[`System.MemoryExtensions.Split`](https://learn.microsoft.com/en-us/dotnet/api/system.memoryextensions.split?view=net-9.0).
## [4.0.0] - 2024-06-12

24
X10D.Tests/src/Time/DateOnlyTests.cs
View File

@ -39,30 +39,6 @@ internal class DateOnlyTests
Assert.That(age, Is.EqualTo(18));
}
[Test]
public void Deconstruct_ShouldDeconstruct_GivenDateOnly()
{
var date = new DateOnly(2017, 12, 31);
date.Deconstruct(out int year, out int month, out int day);
Assert.That(year, Is.EqualTo(2017));
Assert.That(month, Is.EqualTo(12));
Assert.That(day, Is.EqualTo(31));
}
[Test]
public void Deconstruct_ShouldDeconstructToTuple_GivenDateOnly()
{
var date = new DateOnly(2017, 12, 31);
(int year, int month, int day) = date;
Assert.That(year, Is.EqualTo(2017));
Assert.That(month, Is.EqualTo(12));
Assert.That(day, Is.EqualTo(31));
}
[Test]
public void First_ShouldBeSaturday_Given1Jan2000()
{

14
X10D/src/Time/DateOnlyExtensions.cs
View File

@ -39,20 +39,6 @@ public static class DateOnlyExtensions
return value.ToDateTime(default).Age(referenceDate.ToDateTime(default));
}
/// <summary>
/// Deconstructs the current <see cref="DateOnly" /> into its year, month, and day.
/// </summary>
/// <param name="value">The date to deconstruct.</param>
/// <param name="year">When this method returns, contains the year.</param>
/// <param name="month">When this method returns, contains the month.</param>
/// <param name="day">When this method returns, contains the day.</param>
public static void Deconstruct(this DateOnly value, out int year, out int month, out int day)
{
year = value.Year;
month = value.Month;
day = value.Day;
}
/// <summary>
/// Gets a date representing the first occurence of a specified day of the week in the current month.
/// </summary>