oliverbooth/X10D
oliverbooth/X10D
1
0
Fork 0
mirror of https://github.com/oliverbooth/X10D synced 2024-11-23 00:38:47 +00:00
Code Issues

perf: remove redundant 0 check in Sqrt

Browse Source 
This check was a defensive manoeuvrer in the event that the input is 0, but this condition has already been verified to be false with the switch guard clause.

This changes bumps coverage to 100% for Sqrt.
This commit is contained in:
Oliver Booth 2023-03-31 20:40:06 +01:00
parent 3d2baf595b
commit c8ccb1deb8
No known key found for this signature in database
GPG Key ID: 20BEB9DC87961025
3 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
X10D/src/Math/DecimalExtensions.cs
View File

@ -198,11 +198,6 @@ public static class DecimalExtensions
do do
{ {
previous = current; previous = current;
if (previous == 0.0m)
{
return 0;
}
current = (previous + value / previous) / 2; current = (previous + value / previous) / 2;
} while (System.Math.Abs(previous - current) > 0.0m); } while (System.Math.Abs(previous - current) > 0.0m);

5
X10D/src/Math/DoubleExtensions.cs
View File

@ -460,11 +460,6 @@ public static class DoubleExtensions
do do
{ {
previous = current; previous = current;
if (previous == 0.0)
{
return 0;
}
current = (previous + value / previous) / 2; current = (previous + value / previous) / 2;
} while (System.Math.Abs(previous - current) > double.Epsilon); } while (System.Math.Abs(previous - current) > double.Epsilon);

5
X10D/src/Math/SingleExtensions.cs
View File

@ -419,11 +419,6 @@ public static class SingleExtensions
do do
{ {
previous = current; previous = current;
if (previous == 0.0f)
{
return 0;
}
current = (previous + value / previous) / 2; current = (previous + value / previous) / 2;
} while (MathF.Abs(previous - current) > float.Epsilon); } while (MathF.Abs(previous - current) > float.Epsilon);