From c8d2a5cbeca67a65861e07071a4af78a024ab3cc Mon Sep 17 00:00:00 2001 From: Oliver Booth Date: Tue, 29 Nov 2022 18:53:58 +0000 Subject: [PATCH] Call .ConfigureAwait(false) Yes I wrote true, this was a mistake. https://media.tenor.com/YQv2NMgnGmoAAAAC/tom-hanks-forrest-gump.gif --- X10D.DSharpPlus/src/DiscordChannelExtensions.cs | 2 +- X10D.DSharpPlus/src/DiscordGuildExtensions.cs | 4 ++-- X10D.DSharpPlus/src/DiscordMemberExtensions.cs | 4 ++-- X10D.DSharpPlus/src/DiscordMessageExtensions.cs | 12 ++++++------ X10D.DSharpPlus/src/DiscordUserExtensions.cs | 6 +++--- X10D/src/Collections/CollectionExtensions.cs | 2 +- X10D/src/Collections/EnumerableExtensions.cs | 2 +- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/X10D.DSharpPlus/src/DiscordChannelExtensions.cs b/X10D.DSharpPlus/src/DiscordChannelExtensions.cs index 026e8bb..2734af9 100644 --- a/X10D.DSharpPlus/src/DiscordChannelExtensions.cs +++ b/X10D.DSharpPlus/src/DiscordChannelExtensions.cs @@ -75,6 +75,6 @@ public static class DiscordChannelExtensions } #endif - return await client.GetChannelAsync(channel.Id).ConfigureAwait(true); + return await client.GetChannelAsync(channel.Id).ConfigureAwait(false); } } diff --git a/X10D.DSharpPlus/src/DiscordGuildExtensions.cs b/X10D.DSharpPlus/src/DiscordGuildExtensions.cs index 38f8a05..7519bfa 100644 --- a/X10D.DSharpPlus/src/DiscordGuildExtensions.cs +++ b/X10D.DSharpPlus/src/DiscordGuildExtensions.cs @@ -24,7 +24,7 @@ public static class DiscordGuildExtensions } #endif - await Task.WhenAll(guild.Threads.Values.Select(t => t.JoinThreadAsync())).ConfigureAwait(true); + await Task.WhenAll(guild.Threads.Values.Select(t => t.JoinThreadAsync())).ConfigureAwait(false); } /// @@ -58,6 +58,6 @@ public static class DiscordGuildExtensions } #endif - return await client.GetGuildAsync(guild.Id).ConfigureAwait(true); + return await client.GetGuildAsync(guild.Id).ConfigureAwait(false); } } diff --git a/X10D.DSharpPlus/src/DiscordMemberExtensions.cs b/X10D.DSharpPlus/src/DiscordMemberExtensions.cs index 566c815..3fd2020 100644 --- a/X10D.DSharpPlus/src/DiscordMemberExtensions.cs +++ b/X10D.DSharpPlus/src/DiscordMemberExtensions.cs @@ -67,7 +67,7 @@ public static class DiscordMemberExtensions } #endif - DiscordGuild guild = await member.Guild.NormalizeClientAsync(client).ConfigureAwait(true); - return await guild.GetMemberAsync(member.Id).ConfigureAwait(true); + DiscordGuild guild = await member.Guild.NormalizeClientAsync(client).ConfigureAwait(false); + return await guild.GetMemberAsync(member.Id).ConfigureAwait(false); } } diff --git a/X10D.DSharpPlus/src/DiscordMessageExtensions.cs b/X10D.DSharpPlus/src/DiscordMessageExtensions.cs index e179a73..f8317c7 100644 --- a/X10D.DSharpPlus/src/DiscordMessageExtensions.cs +++ b/X10D.DSharpPlus/src/DiscordMessageExtensions.cs @@ -26,8 +26,8 @@ public static class DiscordMessageExtensions } #endif - await Task.Delay(delay).ConfigureAwait(true); - await message.DeleteAsync(reason).ConfigureAwait(true); + await Task.Delay(delay).ConfigureAwait(false); + await message.DeleteAsync(reason).ConfigureAwait(false); } /// @@ -48,8 +48,8 @@ public static class DiscordMessageExtensions } #endif - DiscordMessage message = await task.ConfigureAwait(true); - await message.DeleteAfterAsync(delay, reason).ConfigureAwait(true); + DiscordMessage message = await task.ConfigureAwait(false); + await message.DeleteAfterAsync(delay, reason).ConfigureAwait(false); } /// @@ -83,7 +83,7 @@ public static class DiscordMessageExtensions } #endif - DiscordChannel channel = await message.Channel.NormalizeClientAsync(client).ConfigureAwait(true); - return await channel.GetMessageAsync(message.Id).ConfigureAwait(true); + DiscordChannel channel = await message.Channel.NormalizeClientAsync(client).ConfigureAwait(false); + return await channel.GetMessageAsync(message.Id).ConfigureAwait(false); } } diff --git a/X10D.DSharpPlus/src/DiscordUserExtensions.cs b/X10D.DSharpPlus/src/DiscordUserExtensions.cs index 02f555f..6ab8314 100644 --- a/X10D.DSharpPlus/src/DiscordUserExtensions.cs +++ b/X10D.DSharpPlus/src/DiscordUserExtensions.cs @@ -52,7 +52,7 @@ public static class DiscordUserExtensions try { - return await guild.GetMemberAsync(user.Id).ConfigureAwait(true); + return await guild.GetMemberAsync(user.Id).ConfigureAwait(false); } catch (NotFoundException) { @@ -113,7 +113,7 @@ public static class DiscordUserExtensions try { - DiscordMember? member = await guild.GetMemberAsync(user.Id).ConfigureAwait(true); + DiscordMember? member = await guild.GetMemberAsync(user.Id).ConfigureAwait(false); return member is not null; } catch (NotFoundException) @@ -153,6 +153,6 @@ public static class DiscordUserExtensions } #endif - return await client.GetUserAsync(user.Id).ConfigureAwait(true); + return await client.GetUserAsync(user.Id).ConfigureAwait(false); } } diff --git a/X10D/src/Collections/CollectionExtensions.cs b/X10D/src/Collections/CollectionExtensions.cs index 9279393..ae33488 100644 --- a/X10D/src/Collections/CollectionExtensions.cs +++ b/X10D/src/Collections/CollectionExtensions.cs @@ -69,7 +69,7 @@ public static class CollectionExtensions continue; } - await item.DisposeAsync().ConfigureAwait(true); + await item.DisposeAsync().ConfigureAwait(false); } source.Clear(); diff --git a/X10D/src/Collections/EnumerableExtensions.cs b/X10D/src/Collections/EnumerableExtensions.cs index 909b862..ddba90e 100644 --- a/X10D/src/Collections/EnumerableExtensions.cs +++ b/X10D/src/Collections/EnumerableExtensions.cs @@ -226,7 +226,7 @@ public static class EnumerableExtensions continue; } - await item.DisposeAsync().ConfigureAwait(true); + await item.DisposeAsync().ConfigureAwait(false); } }