From e6025b1a4cd6a188a358c150ec3e2e43bf835733 Mon Sep 17 00:00:00 2001
From: Oliver Booth <me@olivr.me>
Date: Tue, 11 Apr 2023 17:09:14 +0100
Subject: [PATCH] fix: validate null arguments in X10D.Unity

The CA runs are really testing me today.
---
 X10D.Unity/src/ComponentExtensions.cs         |  6 +++
 .../src/Drawing/PolyhedronExtensions.cs       | 42 +++++++++++++++++++
 X10D.Unity/src/GameObjectExtensions.cs        |  6 +++
 3 files changed, 54 insertions(+)

diff --git a/X10D.Unity/src/ComponentExtensions.cs b/X10D.Unity/src/ComponentExtensions.cs
index 6ad7388..01d0a27 100644
--- a/X10D.Unity/src/ComponentExtensions.cs
+++ b/X10D.Unity/src/ComponentExtensions.cs
@@ -14,8 +14,14 @@ public static class ComponentExtensions
     /// <param name="component">The component whose child components to retrieve.</param>
     /// <typeparam name="T">The type of the components to retrieve.</typeparam>
     /// <returns>An array <typeparamref name="T" /> representing the child components.</returns>
+    /// <exception cref="ArgumentNullException"><paramref name="component" /> is <see langword="null" />.</exception>
     public static T[] GetComponentsInChildrenOnly<T>(this Component component)
     {
+        if (component == null)
+        {
+            throw new ArgumentNullException(nameof(component));
+        }
+
         return component.gameObject.GetComponentsInChildrenOnly<T>();
     }
 }
diff --git a/X10D.Unity/src/Drawing/PolyhedronExtensions.cs b/X10D.Unity/src/Drawing/PolyhedronExtensions.cs
index 108b9a8..94cd4ed 100644
--- a/X10D.Unity/src/Drawing/PolyhedronExtensions.cs
+++ b/X10D.Unity/src/Drawing/PolyhedronExtensions.cs
@@ -14,8 +14,14 @@ public static class PolyhedronExtensions
     /// </summary>
     /// <param name="polyhedron">The polyhedron whose vertices to update.</param>
     /// <param name="vertex">The vertex to add.</param>
+    /// <exception cref="ArgumentNullException"><paramref name="polyhedron" /> is <see langword="null" />.</exception>
     public static void AddVertex(this Polyhedron polyhedron, Vector3Int vertex)
     {
+        if (polyhedron is null)
+        {
+            throw new ArgumentNullException(nameof(polyhedron));
+        }
+
         polyhedron.AddVertex(vertex.ToSystemVector());
     }
 
@@ -24,8 +30,14 @@ public static class PolyhedronExtensions
     /// </summary>
     /// <param name="polyhedron">The polyhedron whose vertices to update.</param>
     /// <param name="vertex">The vertex to add.</param>
+    /// <exception cref="ArgumentNullException"><paramref name="polyhedron" /> is <see langword="null" />.</exception>
     public static void AddVertex(this Polyhedron polyhedron, Vector3 vertex)
     {
+        if (polyhedron is null)
+        {
+            throw new ArgumentNullException(nameof(polyhedron));
+        }
+
         polyhedron.AddVertex(vertex.ToSystemVector());
     }
 
@@ -34,8 +46,23 @@ public static class PolyhedronExtensions
     /// </summary>
     /// <param name="polyhedron">The polyhedron whose vertices to update.</param>
     /// <param name="vertices">The vertices to add.</param>
+    /// <exception cref="ArgumentNullException">
+    ///     <para><paramref name="polyhedron" /> is <see langword="null" />.</para>
+    ///     -or-
+    ///     <para><paramref name="vertices" /> is <see langword="null" />.</para>
+    /// </exception>
     public static void AddVertices(this Polyhedron polyhedron, IEnumerable<Vector3Int> vertices)
     {
+        if (polyhedron is null)
+        {
+            throw new ArgumentNullException(nameof(polyhedron));
+        }
+
+        if (vertices is null)
+        {
+            throw new ArgumentNullException(nameof(vertices));
+        }
+
         foreach (Vector3Int vertex in vertices)
         {
             polyhedron.AddVertex(vertex);
@@ -47,8 +74,23 @@ public static class PolyhedronExtensions
     /// </summary>
     /// <param name="polyhedron">The polyhedron whose vertices to update.</param>
     /// <param name="vertices">The vertices to add.</param>
+    /// <exception cref="ArgumentNullException">
+    ///     <para><paramref name="polyhedron" /> is <see langword="null" />.</para>
+    ///     -or-
+    ///     <para><paramref name="vertices" /> is <see langword="null" />.</para>
+    /// </exception>
     public static void AddVertices(this Polyhedron polyhedron, IEnumerable<Vector3> vertices)
     {
+        if (polyhedron is null)
+        {
+            throw new ArgumentNullException(nameof(polyhedron));
+        }
+
+        if (vertices is null)
+        {
+            throw new ArgumentNullException(nameof(vertices));
+        }
+
         foreach (Vector3 vertex in vertices)
         {
             polyhedron.AddVertex(vertex);
diff --git a/X10D.Unity/src/GameObjectExtensions.cs b/X10D.Unity/src/GameObjectExtensions.cs
index 23d7f3c..559ee39 100644
--- a/X10D.Unity/src/GameObjectExtensions.cs
+++ b/X10D.Unity/src/GameObjectExtensions.cs
@@ -13,8 +13,14 @@ public static class GameObjectExtensions
     /// <param name="gameObject">The game object whose child components to retrieve.</param>
     /// <typeparam name="T">The type of the components to retrieve.</typeparam>
     /// <returns>An array <typeparamref name="T" /> representing the child components.</returns>
+    /// <exception cref="ArgumentNullException"><paramref name="gameObject" /> is <see langword="null" />.</exception>
     public static T[] GetComponentsInChildrenOnly<T>(this GameObject gameObject)
     {
+        if (gameObject == null)
+        {
+            throw new ArgumentNullException(nameof(gameObject));
+        }
+
         Transform rootTransform = gameObject.transform;
         var components = new List<T>(gameObject.GetComponentsInChildren<T>());