oliverbooth/oliverbooth.dev
oliverbooth/oliverbooth.dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Activity

refactor: return Ok(...) instead of building a JsonResult

Browse Source
This commit is contained in:
Oliver Booth 2023-08-10 22:55:52 +01:00
parent 9d46d6495e
commit 159e1ad65d
Signed by: oliverbooth
GPG Key ID: 725DB725A0D9EE61
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
OliverBooth/Controllers/BlogApiController.cs
View File

@ -1,6 +1,5 @@
using Humanizer; using Humanizer;
using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Primitives;
using OliverBooth.Data.Blog; using OliverBooth.Data.Blog;
using OliverBooth.Services; using OliverBooth.Services;
@ -20,7 +19,7 @@ public sealed class BlogApiController : ControllerBase
[Route("count")] [Route("count")]
public IActionResult Count() public IActionResult Count()
{ {
return new JsonResult(new { count = _blogService.AllPosts.Count }); return Ok(new { count = _blogService.AllPosts.Count });
} }
[Route("all/{skip:int?}/{take:int?}")] [Route("all/{skip:int?}/{take:int?}")]
@ -34,7 +33,7 @@ public sealed class BlogApiController : ControllerBase
return NotFound(); return NotFound();
} }
return new JsonResult(_blogService.AllPosts.Skip(skip).Take(take).Select(post => new return Ok(_blogService.AllPosts.Skip(skip).Take(take).Select(post => new
{ {
id = post.Id, id = post.Id,
commentsEnabled = post.EnableComments, commentsEnabled = post.EnableComments,
@ -44,7 +43,7 @@ public sealed class BlogApiController : ControllerBase
published = post.Published.ToUnixTimeSeconds(), published = post.Published.ToUnixTimeSeconds(),
formattedDate = post.Published.ToString("dddd, d MMMM yyyy HH:mm"), formattedDate = post.Published.ToString("dddd, d MMMM yyyy HH:mm"),
updated = post.Updated?.ToUnixTimeSeconds(), updated = post.Updated?.ToUnixTimeSeconds(),
humanizedTimestamp = post.Updated?.Humanize() ?? post.Published.Humanize(), humanizedTimestamp = post.Updated?.Humanize() ?? post.Published.Humanize(),
excerpt = _blogService.GetExcerpt(post, out bool trimmed), excerpt = _blogService.GetExcerpt(post, out bool trimmed),
trimmed, trimmed,
url = Url.Page("/Blog/Article", url = Url.Page("/Blog/Article",
@ -63,7 +62,7 @@ public sealed class BlogApiController : ControllerBase
{ {
if (!_blogService.TryGetAuthor(id, out Author? author)) return NotFound(); if (!_blogService.TryGetAuthor(id, out Author? author)) return NotFound();
return new JsonResult(new return Ok(new
{ {
name = author.Name, name = author.Name,
avatarHash = author.AvatarHash, avatarHash = author.AvatarHash,