oliverbooth
/
VpSharp
mirror of https://github.com/oliverbooth/VpSharp
1
0
Fork 0
Code Issues Wiki
243 Commits 4 Branches 2 Tags 1.8 MiB
Commit Graph

243 Commits

Author SHA1 Message Date
Oliver Booth 64eb4190bb
GC.SuppressFinalize(this) 2022-11-30 19:03:49 +00:00
Oliver Booth f040eade95
Remove explicit parameter name 2022-11-30 19:03:40 +00:00
Oliver Booth 14773e1cc4
Suppress CA1815, nonsense here 
We don't need to override equality operators here. These types are struct to reduce needless allocations
 2022-11-30 19:03:07 +00:00
Oliver Booth fbfbab03f3
Suppress CA2000, false positive 
This value is in fact disposed, just not here. See DestroyNative(nint)
 2022-11-30 19:02:17 +00:00
Oliver Booth 220eeeec69
Initialize _pendingBuffer 2022-11-30 19:01:46 +00:00
Oliver Booth cb232cd0d3
Suppress unlikely null value 2022-11-30 19:01:37 +00:00
Oliver Booth 6a16ef6097
Code cleanup 2022-11-30 19:00:40 +00:00
Oliver Booth eef5dcf1c2
catch (VirtualParadiseException) 2022-11-30 18:59:29 +00:00
Oliver Booth a90d2ccc7f
Suppress CA1019, false positive 
CA1019 wants us to expose the parameter as a property, but this value is concatenated to the aliases list which conglomerates all aliases - including the first parameter - into one list
 2022-11-30 18:59:01 +00:00
Oliver Booth f846b43680
ConfigureAwait(false) on awaited tasks 2022-11-30 18:57:57 +00:00
Oliver Booth 189ef770eb
Use ternary for vp_query_cell 
This works because CA wanted us to capture the return var, which we are just discarding. VP sometimes you are cursed but in a good way
 2022-11-30 18:57:27 +00:00
Oliver Booth 9f16e6cc77
Move EnumerateWorldsAsync to Worlds partial 2022-11-30 18:56:33 +00:00
Oliver Booth c2748567fc
Fix nullability (again) 2022-11-30 18:55:42 +00:00
Oliver Booth a8e5fafbb4
Suppres CA1021, we want out parameters here! 2022-11-30 18:53:55 +00:00
Oliver Booth 12ca1b7c18
Use explicit precedence 2022-11-30 18:53:44 +00:00
Oliver Booth 4f123d384e
Order members alphabetically 2022-11-30 18:53:19 +00:00
Oliver Booth 7e69bdce39
Use explicit type when not apparent 2022-11-30 18:52:49 +00:00
Oliver Booth b871b8e74c
Validate lient is in-world before accepting join/invite request 2022-11-30 18:50:18 +00:00
Oliver Booth fd52361a5e
Initialize Path to null 
This value is assigned when the instance is created, so it's guaranteed not to be null when it reaches client code
 2022-11-30 18:48:40 +00:00
Oliver Booth 548a5de2be
Don't use base Exception 2022-11-30 18:47:57 +00:00
Oliver Booth 80679fa8c4
Add missing xmldoc 2022-11-30 18:46:02 +00:00
Oliver Booth 8bbbf170e3
Use NRT where appropriate 2022-11-30 18:43:59 +00:00
Oliver Booth 267c450677
Add helper methods to complement Vector3d operators 2022-11-30 18:40:02 +00:00
Oliver Booth f16349225b
Remove implicit bool cast in JoinResult 2022-11-30 18:39:33 +00:00
Oliver Booth 61042ee5e8
Cast to IntPtr if .NET < 7 2022-11-30 18:39:02 +00:00
Oliver Booth b95de092f8
Don't use target-typed new for method returns 2022-11-30 18:38:51 +00:00
Oliver Booth f640d5e999
Use in parameters for Vector3d static methods 2022-11-30 18:38:13 +00:00
Oliver Booth 17e3795eeb
Discard native return values when irrelevant 2022-11-30 18:37:07 +00:00
Oliver Booth 775f068fe7
Remove redundant readonly modifiers 2022-11-30 18:30:35 +00:00
Oliver Booth 836d48525b
Add missing using directive 2022-11-30 18:30:18 +00:00
Oliver Booth 88483373ee
Fix spacing 2022-11-30 18:25:05 +00:00
Oliver Booth 5019ef94b0
Allow nullable Uri 2022-11-30 18:18:20 +00:00
Oliver Booth ed98531950
Use statement body for CurrentWorld property 2022-11-30 18:17:40 +00:00
Oliver Booth e4f692d599
Throw ArgumentException not IndexOutOfRangeException 2022-11-30 18:17:20 +00:00
Oliver Booth cfd1e4c208
Validate non-null arguments for public API 2022-11-30 18:16:37 +00:00
Oliver Booth cfc73cfb62
Order members alphabetically 2022-11-30 18:14:33 +00:00
Oliver Booth 02b4907c95
Give explicit precedence with parentheses 2022-11-30 18:09:41 +00:00
Oliver Booth b4deeaf92c
Use statement bodies 2022-11-30 18:06:23 +00:00
Oliver Booth 99c08f33ed
Use IReadOnlyList<T> instead of T[] for public API 2022-11-30 18:03:00 +00:00
Oliver Booth 86458129b5
Explicit Ordinal string comparison 2022-11-30 18:01:45 +00:00
Oliver Booth 79129f44d2
Suppress CA1308, lowercase is intended here 2022-11-30 17:57:17 +00:00
Oliver Booth 73d0bc8561
Implement IDisposable 2022-11-30 17:56:51 +00:00
Oliver Booth 656a0b287d
Specify CultureInfo when converting types 2022-11-30 17:56:02 +00:00
Oliver Booth 3abd7b1379
Resolve CA2225, offer methods to complement operators 2022-11-30 17:51:20 +00:00
Oliver Booth 9336511059
Treat analysis warnings as errors 2022-11-30 12:09:19 +00:00
Oliver Booth a6fcad1f7a
Format csproj 2022-11-30 12:01:02 +00:00
Oliver Booth 0549184c60
Suppress CA1812 for value converters 2022-11-30 02:27:19 +00:00
Oliver Booth bb39b2eb62
Seal Connection class 2022-11-30 00:52:40 +00:00
Oliver Booth 0e82236944
Use nint over IntPtr 2022-11-30 00:52:15 +00:00
Oliver Booth af0dbf5259
Use nullable state parameter 2022-11-30 00:48:47 +00:00