2fe3c8b98e
Reduce cyclomatic complexity of VirtualParadisePathObject
...
Just... all of it
2022-11-30 20:14:41 +00:00
554d326819
Call ZString.CreateUtf8StringBuilder
...
Don't instantiate directly, let ZString handle it
2022-11-30 19:58:02 +00:00
99bda9d53f
Suppress CA1814 for revision property
...
revision is a contiguous array in the native SDK, which is best represented with a multidimensional array in C#
2022-11-30 19:30:56 +00:00
7d035c2c2b
Suppress CA1027 false positive
...
The values in this enum are - in fact - contiguous. The use of alias entries causes the analyzer to trip and be a special kind of special.
It's okay Roslyn. We still love you ❤️
2022-11-30 19:26:01 +00:00
1032313dff
Use nint keyword not IntPtr type
2022-11-30 19:24:58 +00:00
031450ca7e
Suppress CA2101 false positive
...
Strings are marshalled using a custom marshaller, this does not apply
2022-11-30 19:24:44 +00:00
8faf25c315
Specify DefaultDllImportSearchPaths
...
This also suppresses a false positive CA5393
2022-11-30 19:24:18 +00:00
ed589508b2
Add NotInWorldException
2022-11-30 19:09:24 +00:00
74ddc12f9d
Rename Native - > NativeMethods
2022-11-30 19:09:01 +00:00
0f0d756925
Use human-friendly ToString returns
2022-11-30 19:07:40 +00:00
00551e7777
Add received world to hot cache
2022-11-30 19:04:54 +00:00
304b043c98
Code cleanup
2022-11-30 19:04:43 +00:00
64eb4190bb
GC.SuppressFinalize(this)
2022-11-30 19:03:49 +00:00
f040eade95
Remove explicit parameter name
2022-11-30 19:03:40 +00:00
14773e1cc4
Suppress CA1815, nonsense here
...
We don't need to override equality operators here. These types are struct to reduce needless allocations
2022-11-30 19:03:07 +00:00
fbfbab03f3
Suppress CA2000, false positive
...
This value is in fact disposed, just not here. See DestroyNative(nint)
2022-11-30 19:02:17 +00:00
220eeeec69
Initialize _pendingBuffer
2022-11-30 19:01:46 +00:00
cb232cd0d3
Suppress unlikely null value
2022-11-30 19:01:37 +00:00
6a16ef6097
Code cleanup
2022-11-30 19:00:40 +00:00
eef5dcf1c2
catch (VirtualParadiseException)
2022-11-30 18:59:29 +00:00
a90d2ccc7f
Suppress CA1019, false positive
...
CA1019 wants us to expose the parameter as a property, but this value is concatenated to the aliases list which conglomerates all aliases - including the first parameter - into one list
2022-11-30 18:59:01 +00:00
f846b43680
ConfigureAwait(false) on awaited tasks
2022-11-30 18:57:57 +00:00
189ef770eb
Use ternary for vp_query_cell
...
This works because CA wanted us to capture the return var, which we are just discarding. VP sometimes you are cursed but in a good way
2022-11-30 18:57:27 +00:00
9f16e6cc77
Move EnumerateWorldsAsync to Worlds partial
2022-11-30 18:56:33 +00:00
c2748567fc
Fix nullability (again)
2022-11-30 18:55:42 +00:00
a8e5fafbb4
Suppres CA1021, we want out parameters here!
2022-11-30 18:53:55 +00:00
12ca1b7c18
Use explicit precedence
2022-11-30 18:53:44 +00:00
4f123d384e
Order members alphabetically
2022-11-30 18:53:19 +00:00
7e69bdce39
Use explicit type when not apparent
2022-11-30 18:52:49 +00:00
b871b8e74c
Validate lient is in-world before accepting join/invite request
2022-11-30 18:50:18 +00:00
fd52361a5e
Initialize Path to null
...
This value is assigned when the instance is created, so it's guaranteed not to be null when it reaches client code
2022-11-30 18:48:40 +00:00
548a5de2be
Don't use base Exception
2022-11-30 18:47:57 +00:00
80679fa8c4
Add missing xmldoc
2022-11-30 18:46:02 +00:00
8bbbf170e3
Use NRT where appropriate
2022-11-30 18:43:59 +00:00
267c450677
Add helper methods to complement Vector3d operators
2022-11-30 18:40:02 +00:00
f16349225b
Remove implicit bool cast in JoinResult
2022-11-30 18:39:33 +00:00
61042ee5e8
Cast to IntPtr if .NET < 7
2022-11-30 18:39:02 +00:00
b95de092f8
Don't use target-typed new for method returns
2022-11-30 18:38:51 +00:00
f640d5e999
Use in parameters for Vector3d static methods
2022-11-30 18:38:13 +00:00
17e3795eeb
Discard native return values when irrelevant
2022-11-30 18:37:07 +00:00
775f068fe7
Remove redundant readonly modifiers
2022-11-30 18:30:35 +00:00
836d48525b
Add missing using directive
2022-11-30 18:30:18 +00:00
88483373ee
Fix spacing
2022-11-30 18:25:05 +00:00
5019ef94b0
Allow nullable Uri
2022-11-30 18:18:20 +00:00
ed98531950
Use statement body for CurrentWorld property
2022-11-30 18:17:40 +00:00
e4f692d599
Throw ArgumentException not IndexOutOfRangeException
2022-11-30 18:17:20 +00:00
cfd1e4c208
Validate non-null arguments for public API
2022-11-30 18:16:37 +00:00
cfc73cfb62
Order members alphabetically
2022-11-30 18:14:33 +00:00
02b4907c95
Give explicit precedence with parentheses
2022-11-30 18:09:41 +00:00
b4deeaf92c
Use statement bodies
2022-11-30 18:06:23 +00:00
